What Makes a Great Weakness System in an RPG

I recently had to update the combat system for Project Bloom and wanted to add a weakness system. In order to make sure I was doing it right I had to do a bit of research into other games....